Changed all perf-db creations to be lazy #3212
Open
+115
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrizztDoUrden
requested review from
JehandadKhan and
junliume
as code owners
DrizztDoUrden
requested review from
averinevg
and removed request for
JehandadKhan and
junliume
averinevg
requested changes
Oct 3, 2024
src/include/miopen/mlo_internal.hpp
Outdated
Comment on lines
170
to
172
| MIOPEN_INTERNALS_EXPORT auto MakeConvDbGetter(const ExecutionContext& ctx) | ||
| -> std::function<PerformanceDb&()>; | ||
|
|
There was a problem hiding this comment.
[R] I think we shouldn't add new things into this file. This file has confusing name, also it probably has a license problem.
| }; | ||
| } | ||
|
|
||
| ConvSolution FindSolution(const ExecutionContext& ctx, |
There was a problem hiding this comment.
Let's add #define FIN_ANY_SOLVER_FIND_SOLUTION_COMPAT 1 and wrap old FindSolution() with #if/#endif.
This code should be removed after the Fin is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes find or similar invokations to not construct any db instance when no tunable solver is applicable or in similar cases. Basically it removes redundant prefetches. After #3078 this can also delay any potential waiting for the db being prefetched, which can reduce expected delays even further.